Skip to content

fix(lb): ignore changes on /32 subnets on ACLs #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Mar 11, 2024

No description provided.

@yfodil yfodil added bug load-balancer Load-balancer issues, bugs and feature requests labels Mar 11, 2024
@yfodil yfodil self-assigned this Mar 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.77%. Comparing base (3f04f81) to head (35fd765).

Files Patch % Lines
scaleway/helpers_lb.go 84.21% 2 Missing and 1 partial ⚠️
scaleway/helpers.go 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2442      +/-   ##
==========================================
+ Coverage   73.74%   73.77%   +0.03%     
==========================================
  Files         229      229              
  Lines       35814    35841      +27     
==========================================
+ Hits        26410    26442      +32     
+ Misses       7124     7121       -3     
+ Partials     2280     2278       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Mar 11, 2024
Merged via the queue into scaleway:master with commit be334e8 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants