Skip to content

chore: migrate httperrors to its own package #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

remyleone
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 6.44172% with 305 lines in your changes are missing coverage. Please review.

Project coverage is 73.48%. Comparing base (4638e19) to head (3fe8e2c).

❗ Current head 3fe8e2c differs from pull request most recent head 4db04cc. Consider uploading reports for the commit 4db04cc to get more accurate results

Files Patch % Lines
scaleway/resource_lb.go 0.00% 3 Missing and 13 partials ⚠️
scaleway/resource_lb_ip.go 0.00% 9 Missing and 1 partial ⚠️
internal/httperrors/http.go 62.50% 9 Missing ⚠️
scaleway/resource_lb_backend.go 0.00% 8 Missing and 1 partial ⚠️
scaleway/resource_rdb_privilege.go 11.11% 8 Missing ⚠️
scaleway/resource_document_db_privilege.go 12.50% 7 Missing ⚠️
scaleway/resource_baremetal_server.go 0.00% 2 Missing and 4 partials ⚠️
scaleway/resource_container_namespace.go 0.00% 2 Missing and 4 partials ⚠️
scaleway/resource_instance_server.go 0.00% 1 Missing and 5 partials ⚠️
scaleway/resource_rdb_acl.go 0.00% 1 Missing and 5 partials ⚠️
... and 86 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
- Coverage   73.50%   73.48%   -0.03%     
==========================================
  Files         234      235       +1     
  Lines       35491    35491              
==========================================
- Hits        26089    26080       -9     
- Misses       7147     7156       +9     
  Partials     2255     2255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone changed the title chore: migrate errs to its own package chore: migrate httperrors to its own package Mar 13, 2024
@remyleone remyleone added this pull request to the merge queue Mar 13, 2024
Merged via the queue into scaleway:master with commit 38c3729 Mar 13, 2024
@remyleone remyleone deleted the errs branch March 13, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants