Skip to content

chore: migrate services to their own packages #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 2, 2024

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone force-pushed the split_services branch 3 times, most recently from 34add81 to c2a7058 Compare March 26, 2024 10:51
@remyleone remyleone force-pushed the split_services branch 3 times, most recently from 780e80b to c0681eb Compare March 27, 2024 15:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 69.37264% with 2275 lines in your changes are missing coverage. Please review.

Project coverage is 71.43%. Comparing base (20236a2) to head (97b387d).

Files Patch % Lines
internal/acctest/fixtures.go 0.00% 173 Missing ⚠️
internal/services/baremetal/server.go 65.10% 116 Missing and 40 partials ⚠️
internal/services/applesilicon/server.go 0.00% 148 Missing ⚠️
internal/services/documentdb/instance.go 48.60% 135 Missing and 12 partials ⚠️
internal/services/documentdb/privilege.go 48.22% 123 Missing and 23 partials ⚠️
internal/services/documentdb/user.go 53.36% 75 Missing and 15 partials ⚠️
internal/services/documentdb/read_replica.go 76.23% 57 Missing and 20 partials ⚠️
internal/services/container/container.go 78.26% 51 Missing and 24 partials ⚠️
internal/services/container/trigger.go 68.26% 61 Missing and 12 partials ⚠️
internal/services/domain/record.go 76.45% 51 Missing and 18 partials ⚠️
... and 49 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2466      +/-   ##
==========================================
- Coverage   73.14%   71.43%   -1.71%     
==========================================
  Files         242      277      +35     
  Lines       35392    35875     +483     
==========================================
- Hits        25887    25628     -259     
- Misses       7285     8028     +743     
+ Partials     2220     2219       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Apr 2, 2024
Merged via the queue into scaleway:master with commit 11e8064 Apr 2, 2024
@remyleone remyleone deleted the split_services branch April 2, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants