Skip to content

fix(lb): unnecessary reattach of private networks #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Apr 12, 2024

No description provided.

@yfodil yfodil added bug load-balancer Load-balancer issues, bugs and feature requests labels Apr 12, 2024
@yfodil yfodil self-assigned this Apr 12, 2024
@yfodil yfodil marked this pull request as ready for review April 12, 2024 13:41
@yfodil yfodil linked an issue Apr 12, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 75.38%. Comparing base (fe86049) to head (0b4d8b6).
Report is 24 commits behind head on master.

Files Patch % Lines
internal/services/lb/helpers_lb.go 86.20% 2 Missing and 2 partials ⚠️
internal/services/lb/lb.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2531      +/-   ##
==========================================
+ Coverage   71.43%   75.38%   +3.94%     
==========================================
  Files         277      278       +1     
  Lines       35875    30728    -5147     
==========================================
- Hits        25628    23164    -2464     
+ Misses       8028     5339    -2689     
- Partials     2219     2225       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Apr 16, 2024
Merged via the queue into scaleway:master with commit 604759f Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attaching/detaching private network of lb reattach all private networks
3 participants