Skip to content

fix(logger): set provider logger as sdk-go logger #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(logger): set provider logger as sdk-go logger #2539

merged 1 commit into from
Apr 17, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Apr 17, 2024

This fix the need of SCW_DEBUG=1 to get requests logs. Only TF_LOG=DEBUG is needed with this change.
This logger was made to replace the sdk logger as specified in logger.Logger docstring.

@Codelax Codelax added the bug label Apr 17, 2024
@Codelax Codelax self-assigned this Apr 17, 2024
@remyleone remyleone added this pull request to the merge queue Apr 17, 2024
Merged via the queue into scaleway:master with commit 1b5f296 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@Vinzius Vinzius Vinzius approved these changes

Assignees

@Codelax Codelax

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Codelax @remyleone @Vinzius