Skip to content

feat(cockpit): migrate tokens to regional v1 #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Apr 23, 2024

No description provided.

@yfodil yfodil added enhancement observability Cockpit observability issues, bugs and feature requests labels Apr 23, 2024
@yfodil yfodil self-assigned this Apr 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 71.22%. Comparing base (fe86049) to head (326315f).
Report is 45 commits behind head on master.

Files Patch % Lines
internal/services/cockpit/helpers_cockpit.go 26.66% 11 Missing ⚠️
internal/services/cockpit/types.go 83.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
- Coverage   71.43%   71.22%   -0.22%     
==========================================
  Files         277      329      +52     
  Lines       35875    33012    -2863     
==========================================
- Hits        25628    23513    -2115     
+ Misses       8028     7221     -807     
- Partials     2219     2278      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yfodil yfodil marked this pull request as ready for review April 23, 2024 11:21
@Codelax Codelax added this pull request to the merge queue Apr 24, 2024
Merged via the queue into scaleway:master with commit 3b6fbbd Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement observability Cockpit observability issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants