-
Notifications
You must be signed in to change notification settings - Fork 131
feat(jobs): support secret manager references in serverless jobs defi… #3030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac490ab
to
9b26c35
Compare
remyleone
reviewed
Apr 8, 2025
e6b8d0f
to
312b8cb
Compare
2763160
to
1a97020
Compare
yfodil
reviewed
Apr 14, 2025
yfodil
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this issue, this PR implements the secret reference ressources
Example
Example of
terraform plan
with asecret_reference
parameter updateNote the update part is implemented by hashing the value that could be edited by the user,
the new values not found in the old ones will be created,
the old values not found in the new ones will be deleted