Skip to content

feat(k8s): read pool's private ips #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented May 5, 2025

This PR adds the private_ips exported field of the pool resource schema.

Left to-do:

  • Handle 403 on IPAM
  • Move private ips as an node attribute and not as a pool attribute
  • Update doc accordingly
  • Update cassettes

@Mia-Cross Mia-Cross added the k8s Kubernetes Kapsule issues, bugs and feature requests label May 5, 2025
@Mia-Cross Mia-Cross self-assigned this May 5, 2025
@Mia-Cross Mia-Cross force-pushed the k8s_pool_read_private_ips branch from b85f46a to 0639b57 Compare May 5, 2025 18:35
@Mia-Cross Mia-Cross marked this pull request as ready for review May 5, 2025 19:37
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners May 5, 2025 19:37
@Mia-Cross Mia-Cross force-pushed the k8s_pool_read_private_ips branch from 0de5d4d to 535dc66 Compare May 5, 2025 20:36
@Mia-Cross Mia-Cross marked this pull request as draft May 6, 2025 09:45
@Mia-Cross Mia-Cross force-pushed the k8s_pool_read_private_ips branch 2 times, most recently from 851f37b to 033b475 Compare May 15, 2025 09:10
@Mia-Cross Mia-Cross force-pushed the k8s_pool_read_private_ips branch from 033b475 to 793d53a Compare May 15, 2025 09:57
@Mia-Cross Mia-Cross marked this pull request as ready for review May 15, 2025 09:57
@remyleone remyleone added this pull request to the merge queue May 15, 2025
Merged via the queue into scaleway:master with commit d2789d8 May 15, 2025
45 checks passed
@Mia-Cross Mia-Cross deleted the k8s_pool_read_private_ips branch May 15, 2025 12:51
jremy42 pushed a commit that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants