Skip to content

feat(instance): read private ips #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented May 5, 2025

This PR adds the private_ips exported field on instance server and private NIC resource schema.

@Mia-Cross Mia-Cross added the instance Instance issues, bugs and feature requests label May 5, 2025
@Mia-Cross Mia-Cross self-assigned this May 5, 2025
@Mia-Cross Mia-Cross changed the title feat(instance): read private nic's private ips feat(instance): read private ips May 5, 2025
@github-actions github-actions bot added vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw labels May 5, 2025
@Mia-Cross Mia-Cross force-pushed the instance_read_pnic_private_ips branch 2 times, most recently from b589390 to 8ec4b6b Compare May 5, 2025 22:35
@Mia-Cross Mia-Cross marked this pull request as ready for review May 5, 2025 22:55
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners May 5, 2025 22:55
@Mia-Cross Mia-Cross marked this pull request as draft May 6, 2025 16:50
@Mia-Cross Mia-Cross force-pushed the instance_read_pnic_private_ips branch 3 times, most recently from 59883f7 to 00790e1 Compare May 13, 2025 18:26
@Mia-Cross Mia-Cross marked this pull request as ready for review May 13, 2025 18:26
@Mia-Cross Mia-Cross force-pushed the instance_read_pnic_private_ips branch from 00790e1 to 860941b Compare May 13, 2025 18:28
remyleone
remyleone previously approved these changes May 13, 2025
@remyleone remyleone added this pull request to the merge queue May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 13, 2025
@Mia-Cross Mia-Cross force-pushed the instance_read_pnic_private_ips branch from 860941b to e51c85b Compare May 14, 2025 09:57
@Mia-Cross Mia-Cross force-pushed the instance_read_pnic_private_ips branch from e51c85b to c1002a2 Compare May 14, 2025 13:00
@remyleone remyleone added this pull request to the merge queue May 14, 2025
Merged via the queue into scaleway:master with commit 942001a May 14, 2025
45 checks passed
@Mia-Cross Mia-Cross deleted the instance_read_pnic_private_ips branch May 14, 2025 13:25
jremy42 pushed a commit that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants