feat(container): vpc integration #3158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
added
enhancement
container
Mia-Cross
force-pushed
the
container_vpc_integration
branch
4 times, most recently
from
c467ee7 to
9a089d8
Compare
Mia-Cross
force-pushed
the
container_vpc_integration
branch
from
9a089d8 to
838226e
Compare
remyleone
reviewed
Jun 17, 2025
| - DENY | ||
| X-Request-Id: | ||
| - d3b7c8ba-8e96-476b-970e-27ba92704224 | ||
| status: 400 Bad Request |
There was a problem hiding this comment.
I'm not sure we should merge that. This request does not look ok
There was a problem hiding this comment.
I wanted to test the fact that legacy namespaces are not compatible with VPC and that activating the feature in the namespace should recreate it with ForceNew, therefore changing its ID.
I can remove the 2nd step if we prefer not to test whether the error occurs, but only the resource recreation.
remyleone
previously approved these changes
Jun 18, 2025
remyleone
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.