fix: add logging for file inclusion #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds detailed logging to the file inclusion/exclusion logic in each_unignored_file, along with new tests to verify include/exclude patterns, nested .gitignore behavior, and build_dir support.
- Introduce
logger.infocalls to explain why files are included or excluded at each decision point - Add comprehensive tests for default behavior, include/exclude overrides, gitignore interactions, nested ignores, build directory exclusion, and edge cases
- Update
changelog.mdto document the new logging feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_file_processor.py | New tests for each_unignored_file covering include/exclude, nested ignores, build_dir, and edge cases |
| src/scikit_build_core/build/_file_processor.py | Added logger.info statements to trace inclusion/exclusion logic |
| docs/about/changelog.md | Changelog entry for the new logging feature |
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1105. Pulled from #1048, also added tests for the current behavior.