Skip to content

[pre-commit.ci] pre-commit autoupdate #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Apr 4, 2022

updates:
- [github.com/asottile/setup-cfg-fmt: v1.20.0 → v1.20.1](asottile/setup-cfg-fmt@v1.20.0...v1.20.1)
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #395 (f8ea32d) into master (ca73302) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files          29       29           
  Lines        1310     1310           
=======================================
  Hits         1182     1182           
  Misses        128      128           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca73302...f8ea32d. Read the comment docs.

@eduardo-rodrigues eduardo-rodrigues deleted the pre-commit-ci-update-config branch April 4, 2022 22:11
@henryiii
Copy link
Member

henryiii commented Apr 4, 2022

FYI, this is broken due to daisylb/setup-nox#419. I can work around it with a simple composite action, but will need to find a good place to put it.

 name: Setup Nox
 description: 'Prepares all python versions for nox'

 runs:
   using: composite
   steps:
     - uses: actions/setup-python@v3
       with:
         python-version: "pypy-3.7"
     - uses: actions/setup-python@v3
       with:
         python-version: "pypy-3.8"
     - uses: actions/setup-python@v3
       with:
         python-version: "pypy-3.9"
     - uses: actions/setup-python@v3
       with:
         python-version: "3.6"
     - uses: actions/setup-python@v3
       with:
         python-version: "3.7"
     - uses: actions/setup-python@v3
       with:
         python-version: "3.8"
     - uses: actions/setup-python@v3
       with:
         python-version: "3.9"
     - uses: actions/setup-python@v3
       with:
         python-version: "3.10"
     - name: "Install nox"
       run: pipx install nox
       shell: bash
     - name: Prepare color
       run: FORCE_COLOR=3 >> $GITHUB_ENV
       shell: bash

@henryiii
Copy link
Member

henryiii commented Apr 4, 2022

Why was this closed and deleted? The issue will show up on all PRs, it's due to an upgrade in pypy version on the GHA runners.

@eduardo-rodrigues
Copy link
Member

Thank you for the info. I have no time right now to dwell on the issue, hence closed this MR since the change is a patch version update afterall, which is no priority. But feel free to act if you know-how.

@henryiii
Copy link
Member

henryiii commented Apr 4, 2022

Then leave it open (and especially, don't delete the whole branch). Eventually one of us will get to it. Especially since the change in the PR didn't cause the breakage, this will just come up on the very next PR or rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants