Skip to content

Fix reporting and add a minimal set of it-tests #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

jozic
Copy link
Collaborator

@jozic jozic commented Dec 10, 2023

Seems like #105 broke site functionality by bumping maven-reporting-api to 3.1.0 but leaving incompatible doxia-site-renderer.
I was able to run scoverage:report in https://github.com/scoverage/scoverage-maven-samples but not mvn verify site.
So this PR does two things:

@jozic jozic marked this pull request as ready for review December 10, 2023 23:27
@jozic
Copy link
Collaborator Author

jozic commented Dec 10, 2023

@ckipp01 could you please kindly review?
Thank you

@jozic jozic requested a review from ckipp01 December 10, 2023 23:28
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance this looks good!

@jozic jozic merged commit 03a7a42 into master Dec 14, 2023
@jozic jozic deleted the fix-reporting-and-add-it-tests branch December 14, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants