Swift Concurrency Part 4 - Weaver --mainactor (command line option) #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://scribdjira.atlassian.net/browse/IPT-9571 - bump weaver version up to 1.1.6 (from previous 1.1.5) - by default, weaver 1.1.6 generates the exact same dependency output as 1.1.5; however, if the --mainactor command line option is included, it will now output extra @mainactor annotations, as well as a bit of extra code tweaks, to satisfy Swift Concurrency checks - Note: tweak Makefile (as generate-xcodeproj is no longer supported) Tested weaver 1.1.6 on both current iScribd codebase WITHOUT --mainactor as well as the Swift Concurrency branch WITH --mainactor (where @mainactor and tweaked code is correctly generated) Note: Swift Concurrency Branch: "rjc-swiftconcurrency-checkpoint" --- Extra note: "rake weaver" make be needed to get latest version of weaver
rjchrhl
changed the title
skz
reviewed
Sep 27, 2024
|
I confirm, that the code of a Weaver builds successfully and Everand application builds and runs successfully, when built with Weaver 1.1.6! Job well done Sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaver: add a
--mainactorcommand line option for Swift ConcurrencyJIRA: https://scribdjira.atlassian.net/browse/IPT-9571
bump weaver version up to 1.1.6 (from previous 1.1.5)
by default, weaver 1.1.6 generates the exact same dependency output as 1.1.5
however, if the
--mainactorcommand line option is included (as part of the Weaver Build Phases in various Xcode targets), it will now output extra "@ MainActor" annotations, as well as a bit of extra code tweaks, to satisfy Swift Concurrency checksNote: tweak Makefile (as generate-xcodeproj is no longer supported)
Tested weaver 1.1.6 on both current iScribd codebase WITHOUT
--mainactoras well as the Swift Concurrency branch WITH--mainactor(where@ MainActorand modified code is correctly generated)Fully compiled iOS apps and successfully ran them on my iPhone and iPad.
Note: Swift Concurrency Branch is "rjc-swiftconcurrency-checkpoint"
Extra note: "rake weaver" may be needed to get latest version of weaver (after a new release is made)