feature Added serde Serialize and Deserialize for some Cql value types. Counter, CqlVarint, CqlDuration and CqlTimeuuid #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wprzytula
requested changes
Jun 2, 2025
scylla-cql/src/value.rs
Outdated
Comment on lines
28
to
33
| impl From<i64> for Counter { | ||
| fn from(value: i64) -> Self { | ||
| Counter(value) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@Lorak-mmk I recall you are against such conversions, am I correct?
Comment on lines
+28
to
+60
| // serde Serialize implementation for Counter | ||
| #[cfg(feature = "serde")] | ||
| impl serde::Serialize for Counter { | ||
| fn serialize<S>(&self, serializer: S) -> StdResult<S::Ok, S::Error> | ||
| where | ||
| S: serde::Serializer { | ||
| serializer.serialize_i64(self.0) | ||
| } | ||
| } | ||
|
|
||
| // serde Deserialize implementation for Counter | ||
| #[cfg(feature = "serde")] | ||
| impl<'de> serde::Deserialize<'de> for Counter { | ||
| fn deserialize<D>(deserializer: D) -> StdResult<Self, D::Error> | ||
| where | ||
| D: serde::Deserializer<'de> { | ||
| struct CounterVisitor; | ||
|
|
||
| impl<'de> serde::de::Visitor<'de> for CounterVisitor { | ||
| type Value = Counter; | ||
|
|
||
| fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result { | ||
| formatter.write_str("Expecting i64 data type!") | ||
| } | ||
|
|
||
| fn visit_i64<E>(self, v: i64) -> StdResult<Self::Value, E> | ||
| where | ||
| E: serde::de::Error, { | ||
| Ok(Counter(v)) | ||
| } | ||
| } | ||
|
|
||
| deserializer.deserialize_i64(CounterVisitor) |
There was a problem hiding this comment.
❓ Why do need to manually implement serde traits? I'd think that the #[derive(serde::Deserialize)] should do the job.
Comment on lines
+712
to
715
| /// | ||
| /// serde traits not necessary. use chrono::DateTime<chrono::Utc> | ||
| #[derive(Clone, Copy, PartialEq, Eq, Debug)] | ||
| pub struct CqlTimestamp(pub i64); |
There was a problem hiding this comment.
♻️ This comment is unclear. What are serde trait not necessary for? How is the user supposed to use chrono::DateTime and what for?
|
Please fill the whole pre-review checklist; don't delete any entries from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added serde Derive traits to CqlTimeuuid, Counter, CqlVarint and CqlDuration