Add flag to db #410
Open
Add flag to db #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates flag submission handling by recording all submitted flags in the userChallenges DB and modifies responses accordingly.
- Adds detailed error checking after updating user challenge tries.
- Saves both correct and incorrect flag submissions in the database.
- Enhances API responses to include the submitted flag field.
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api/submit.go | Implements flag saving in both correct and incorrect cases and adds extra error checking. |
| api/response.go | Adds a new JSON field for the flag in flag submission responses. |
| api/info.go | Includes the flag in the submission information sent to clients. |
Files not reviewed (5)
- api/docs/swagger.json: Language not supported
- api/docs/swagger.yaml: Language not supported
- api/docs/swagger/swagger.json: Language not supported
- api/docs/swagger/swagger.yaml: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
api/submit.go:229
- [nitpick] Consider renaming 'UserChallengesEntry' to 'userChallengesEntry' for consistency with Go naming conventions.
UserChallengesEntry := database.UserChallenges{
| @@ -215,29 +226,27 @@ func submitFlagHandler(c *gin.Context) { | |||
| } | |||
| } else { | |||
| if challenge.Flag != flag { | |||
| UserChallengesEntry := database.UserChallenges{ | |||
| CreatedAt: time.Time{}, | |||
There was a problem hiding this comment.
The 'CreatedAt' field is initialized with time.Time{}, which results in a zero timestamp; consider using time.Now() to record the actual submission time.
Suggested change
| CreatedAt: time.Time{}, | |
| CreatedAt: time.Now(), |
Copilot uses AI. Check for mistakes.
v1bh475u
reviewed
Apr 16, 2025
|
Anything to fix here ? |
|
Yes. Please make the change suggested by copilot. |
|
@v1bh475u, is there anything else to add other than copilot fixes? |
|
Nope. All good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all the flags submitted by the user to the userChallenges DB.