-
Notifications
You must be signed in to change notification settings - Fork 330
Add Inequality CAG #2405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Inequality CAG #2405
Conversation
Task linked: CU-86b42406t SDV - Add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/single-table-CAG #2405 +/- ##
============================================================
+ Coverage 98.55% 98.56% +0.01%
============================================================
Files 65 66 +1
Lines 6425 6563 +138
============================================================
+ Hits 6332 6469 +137
- Misses 93 94 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
74151e2
to
2cc3cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good!
I let some suggestions about the previous code definition but mainly can we ensure that any parameter setting is done during fit()
instead of transform()
.
I also have one question regarding the single-table check in validate()
, maybe something in the base should be updated.
fd4882b
to
f9d68b7
Compare
Co-authored-by: Gaurav Sheni <[email protected]>
Co-authored-by: Gaurav Sheni <[email protected]>
Co-authored-by: Gaurav Sheni <[email protected]>
Co-authored-by: Gaurav Sheni <[email protected]>
Co-authored-by: Gaurav Sheni <[email protected]>
CU-86b42406t, Resolve #2384.