Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here are a few improvements I discovered while working on Metabase.
The first commit addresses the following issue. Binding dynamic variables is comparatively quite expensive.
honey.sql/format
binds a lot of dynvars, but most of them usually don't receive meaningful values. A different approach is possible – prepare a bindings map that would contain only the vars with values that actually have changed, and pass that towith-bindings
macro. Here are ad-hoc benchmark results obtained from Metabase tests:So, -20% allocations and -10% execution time.
The second commit ensures that
xs
passed toformat-values
is a vector because this function traversesxs
multiple times using reduce, and the latter is inefficient for arbitrary seqs. The commit also contains a few minor changes that swap lazy seq processing for transducers.