Skip to content

[Smart Hashing] Cleanup #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Update reddit conversions test case

ce08232
Select commit
Loading
Failed to load commit list.
Merged

[Smart Hashing] Cleanup #2879

Update reddit conversions test case
ce08232
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2025 in 0s

78.11% (+0.07%) compared to 98f6a18

View this Pull Request on Codecov

78.11% (+0.07%) compared to 98f6a18

Details

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (98f6a18) to head (ce08232).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/destinations/dynamic-yield-audiences/helpers.ts 60.00% 2 Missing ⚠️
...tinations/delivrai-activate/updateSegment/index.ts 66.66% 1 Missing ⚠️
.../src/destinations/dynamic-yield-audiences/index.ts 0.00% 1 Missing ⚠️
...ions/dynamic-yield-audiences/syncAudience/index.ts 0.00% 1 Missing ⚠️
...ations/reddit-conversions-api/customEvent/index.ts 50.00% 1 Missing ⚠️
...ions/reddit-conversions-api/standardEvent/index.ts 50.00% 1 Missing ⚠️
...stinations/tiktok-audiences/addToAudience/index.ts 50.00% 1 Missing ⚠️
...src/destinations/tiktok-audiences/addUser/index.ts 50.00% 1 Missing ⚠️
...tions/tiktok-audiences/removeFromAudience/index.ts 50.00% 1 Missing ⚠️
.../destinations/tiktok-audiences/removeUser/index.ts 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
+ Coverage   78.03%   78.11%   +0.07%     
==========================================
  Files        1050     1050              
  Lines       19457    19438      -19     
  Branches     3771     3734      -37     
==========================================
  Hits        15184    15184              
- Misses       2968     2972       +4     
+ Partials     1305     1282      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov