account for startSectionEdit signature change (backwards compatible) #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble) In dokuwiki/dokuwiki#2220 the signature of \Doku_Renderer_xhtml::startSectionEdit was changed in a way that breaks backwards compatibility. In a previous post-Frusterick Manners PR, dokuwiki/dokuwiki#2115, the constant SEC_EDIT_PATTERN was introduced. This allows us to use this constant to differentiate between Frusterick Manners and Greebo releases and use the respective argument types. This added complexity can be removed when Frusterick Manners is no longer supported by the wrap plugin or DokuWiki core is adjusted to be backwards compatible.
micgro42
changed the title
This was referenced Mar 25, 2018
Closed
|
Looks good. Thank you fixing it and making it backwards-compatible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dokuwiki/dokuwiki#2220 the signature of
\Doku_Renderer_xhtml::startSectionEditwas changed in a way that breaks backwards compatibility.In a previous post-Frusterick Manners PR, dokuwiki/dokuwiki#2115, the constant
SEC_EDIT_PATTERNwas introduced. This allows using this constant to differentiate between Frusterick Manners and Greebo releases and to use the respective argument types.This added complexity can be removed when Frusterick Manners is no longer supported by the wrap plugin or DokuWiki core is adjusted to be backwards compatible.