Skip to content

[MISC] rename seqan3::views::trim to seqan3::views::trim_quality #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

wvdtoorn
Copy link
Contributor

@wvdtoorn wvdtoorn requested review from a team and simonsasse and removed request for a team August 12, 2020 09:52
@wvdtoorn wvdtoorn changed the base branch from master to release-3.0.2 August 12, 2020 10:31
@wvdtoorn wvdtoorn changed the base branch from release-3.0.2 to master August 12, 2020 10:37
@wvdtoorn wvdtoorn changed the base branch from master to release-3.0.2 August 12, 2020 10:38
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #2025 into release-3.0.2 will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0.2    #2025   +/-   ##
==============================================
  Coverage          97.89%   97.89%           
==============================================
  Files                262      263    +1     
  Lines               9863     9879   +16     
==============================================
+ Hits                9655     9671   +16     
  Misses               208      208           
Impacted Files Coverage Δ
include/seqan3/range/views/trim_quality.hpp 100.00% <ø> (ø)
...e/seqan3/search/detail/search_scheme_algorithm.hpp 94.53% <0.00%> (-0.03%) ⬇️
include/seqan3/search/search.hpp 100.00% <0.00%> (ø)
include/seqan3/range/views/take_until.hpp 98.24% <0.00%> (ø)
include/seqan3/core/algorithm/configuration.hpp 100.00% <0.00%> (ø)
include/seqan3/search/detail/policy_max_error.hpp 100.00% <0.00%> (ø)
...an3/search/detail/policy_search_result_builder.hpp 100.00% <0.00%> (ø)
.../search/detail/unidirectional_search_algorithm.hpp 100.00% <0.00%> (ø)
.../algorithm/configuration_element_parallel_mode.hpp 100.00% <0.00%> (ø)
include/seqan3/search/configuration/on_result.hpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf04354...df457a4. Read the comment docs.

Copy link
Member

@simonsasse simonsasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Thanks!

@eseiler eseiler requested review from a team and smehringer and removed request for a team August 13, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename seqan3::views::trim to seqan3::views::trim_quality
3 participants