Skip to content

[FIX,INFRA] cmake: version variables cannot be forced #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Apr 24, 2025

Forced cache will cause the variable to be always set to the value defined in the package lock.
We actually want to be able to overwrite this.

Preferably, we would like to

  • Overwrite if given on CLI. Otherwise, use default.
  • On reconfigure, revert to default if not given.
  • Have the variables available in the parent project (CPM version update script).

This doesn't really seem possible, see https://github.com/eseiler/misc/tree/main/cmake_set for some examples.

The drawback of CACHE is that changed default versions are not honored on a simple reconfigure.

forced = no overwrite from outside
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 24, 2025
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3361

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (5d07997) to head (4140e50).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3361   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         270      270           
  Lines       11913    11913           
  Branches      103      103           
=======================================
  Hits        11689    11689           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 24, 2025
@eseiler eseiler merged commit a08b48c into seqan:main Apr 24, 2025
40 checks passed
@eseiler eseiler deleted the fix/cmake branch April 24, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants