servo_arc: make track_alloc_size feature a default feature #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico Burns <[email protected]>
jdm
approved these changes
Apr 22, 2025
|
@jdm Can we get a |
Loirooriol
added a commit
to Loirooriol/servo
that referenced
this pull request
Apr 29, 2025
servo/stylo@0eaeea3...03ffc85 - servo/stylo#173 Use web_atoms crate - servo/stylo#174 servo_arc: make track_alloc_size feature a default feature Signed-off-by: Oriol Brufau <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Apr 29, 2025
servo/stylo@0eaeea3...03ffc85 - servo/stylo#173 Use web_atoms crate - servo/stylo#174 servo_arc: make track_alloc_size feature a default feature Testing: unneeded, no behavior change Signed-off-by: Oriol Brufau <[email protected]>
|
@jdm bumped into this issue from lol-html, would love to see |
|
Sorry about that, I missed #174 (comment) when Nico first asked. Published! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #129 for users that have default features enabled (and it will be the only default feature so there's no reason not to have default features enabled).
Changes made
track_alloc_sizefeature a default featureservo_arcto0.4.1Alternatives
Arguably ought to be the behaviour with no features enabled, and there ought to be a
dont_track_alloc_sizefeature that disables the tracking for Gecko (I believe the combination of having this disabled and using an allocator that requires accurate tracking is actually UB), but this is the simpler change that will likely fix the problem for almost everyone in practice.