fix: Update file extension handling in toAliasedImport function #7549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damien-schneider is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7548 fix
This pull request refines the
toAliasedImportfunction inupdate-files.tsto handle multi-dot filenames more robustly. The key change ensures that the file extension is correctly identified even for filenames with multiple dots.Improvements to file extension handling:
packages/shadcn/src/utils/updaters/update-files.ts: Updated the logic to determine the file extension by usinglastIndexOf('.'), ensuring that multi-dot filenames (e.g.,message-demo.const.tsx) are split correctly on the final dot. This change also adjusts how the remaining portion of the filename is calculated.