-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Select custom color for theme creation for #7545 #7588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
learnwithsatyam
wants to merge
20
commits into
shadcn-ui:main
Choose a base branch
from
learnwithsatyam:Select-custom-color-for-theme-creation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Select custom color for theme creation for #7545 #7588
learnwithsatyam
wants to merge
20
commits into
shadcn-ui:main
from
learnwithsatyam:Select-custom-color-for-theme-creation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and dark varients for the custom theme
…ary-foreground color based on the give primary color for v3
…e primary-foreground color based on the give primary color for v4
… copy button to copy the generated theme he get shown the correct theme
…copying the generated theme to clipboard will function correctly for the custom themes
…d on what the primary color is
@learnwithsatyam is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
@shadcn now the custom themes tab is also support on mobile devices. I have uploaded a demo on twitter because GitHub is not allowing more than 10 mb video file : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shadcn and @Jacksonmills I worked on providing custom theme generation support directly in the website. Now just like we have predefined themes like "green", "rose", "violet", "orange" , etc we also have a "custom" theme tab where the user can select a color from color picker and then below he can also see in real time how the theme or shadcn components will look for that color.
Related to #7545
Ref #7545
See #7545
He can then click on copy button to copy theme for tailwind v3 and v4 both. Please let me know if you have any questions.
You can directly message me on twitter : https://x.com/sattyshivhare
I really worked a lot for this. I thought this will be easy because I thought all I need to do is change the colors but man this really took grunt work and a lot of time to work 😂
Here is a working demo for the changes. The video quality is bad because GitHub won't let me upload more than 10 mb size :
Custom.Theme.PR.Request.video.mp4