Skip to content

ajm mp3: fix resampling #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

roamic
Copy link
Collaborator

@roamic roamic commented Nov 7, 2024

Fixes a crash in Journey

@ElBread3
Copy link
Contributor

ElBread3 commented Nov 7, 2024

With this (and a fresh extract) Journey is now at:

[Render.Vulkan] <Info> vk_pipeline_cache.cpp:CompileModule:396: Compiling fs shader 0x9de9cfa1 
[Render.Vulkan] <Info> vk_pipeline_cache.cpp:CompileModule:396: Compiling vs shader 0xfcafb5f 
[Render.Vulkan] <Info> vk_pipeline_cache.cpp:CompileModule:396: Compiling fs shader 0x65bda6af 
[Render.Vulkan] <Info> vk_pipeline_cache.cpp:CompileModule:396: Compiling vs shader 0x458f1574 
[Render.Vulkan] <Info> vk_pipeline_cache.cpp:CompileModule:396: Compiling cs shader 0x15dc6df4 
[Render.Vulkan] <Error> image_view.cpp:ImageViewInfo:124: Storage image (num_comps = 1) requires swizzling [RRR1]
[Render.Vulkan] <Info> vk_pipeline_cache.cpp:CompileModule:396: Compiling fs shader 0xbdf6f21f 
[Tty] <Info> libkernel.cpp:ps4__write:222: SCREAM: Didn't find child sound named -> CHD_SmalClothPlacement-StrongWind_L
[Render.Vulkan] <Info> vk_pipeline_cache.cpp:CompileModule:396: Compiling vs shader 0xf6ea7735 
[Tty] <Info> libkernel.cpp:ps4__write:222: SCREAM: Didn't find child sound named -> CHD_SmalClothPlacement-StrongWind_L
[Debug] <Critical> page_manager.cpp:operator():152: Assertion Failed!
Region protection failed

@georgemoralis georgemoralis merged commit 75d2181 into shadps4-emu:main Nov 8, 2024
10 checks passed
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 9, 2024
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 12, 2024
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 12, 2024
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 12, 2024
@roamic roamic deleted the fix-ajm-mp3-resampling branch November 16, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants