Skip to content

Fix depth bias #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Fix depth bias #1538

merged 1 commit into from
Nov 16, 2024

Conversation

roamic
Copy link
Collaborator

@roamic roamic commented Nov 16, 2024

Gnm uses depth bias scale in 1/16 units while Vulkan uses 1/1 units.
Before:
Screenshot_2024-11-16_091819
After:
Screenshot_2024-11-16_091618

@leon22heart
Copy link

Although the build file is not based on tess , it truly fixes the missing legs / pedestals / buildings bases . A quality of life fix.

@AwesomeSoftware79
Copy link

It seems like this PR solves some problems with some floors that had some weird transparency problems?

i.e. this floor in Old Yharnam:

using main:
image

using this PR's branch:
image

How to reach this point on the game:
https://youtu.be/pv-oyjBXepM?t=631

@bigol83
Copy link
Contributor

bigol83 commented Nov 16, 2024

This also fixes the eyelids in Red Dead Redemption faces

Master

Immagine 2024-11-16 115910

PR

Immagine 2024-11-16 120225

@GHU7924
Copy link

GHU7924 commented Nov 16, 2024

Before

Before

After

After

@Linear524
Copy link

Awesome fix !!!
Also this is an interesting case - RPCS3 suffer from the same precision bug for years and it still not completely solved yet for some titles. But here - already fixed corrupted geometry ! :)
Great work comrade )))

@AwesomeSoftware79
Copy link

Before

Before

After

After

What is the difference? I can not see anything :)

@NiclasNike
Copy link

Works really great, tested most areas of the game today.
Left without this fix, right has it:
image

@georgemoralis georgemoralis merged commit e1fecda into shadps4-emu:main Nov 16, 2024
10 checks passed
@roamic roamic deleted the fix-depth-bias branch November 16, 2024 18:15
@Foul-Tarnished Foul-Tarnished mentioned this pull request Nov 17, 2024
Dr-42 pushed a commit to Dr-42/shadPS4 that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants