Fixed false-positive image reuploads #1557
Conversation
|
tried a full run in central yharnam, it is greatly reduced but I still got one (and it's way more purple than it used to be, also got it on one broken crate) great work ! |
|
Improved a lot, but still a couple of rainbow effects here and there (once in about 45 min.)-
|
|
I made a circle in Central Yharnam, and during that time I had only one moment: Edit: If something needs to be entered in the Log Filter, then write it, I will test it later if necessary. |
|
|
|
This fixes half of false-positive image re-uploads. The one we can easily detect. The other half is a lot more complicated to spot so will be out of scope of this PR. |
roamic
force-pushed
the
fix-false-positive-image-reuploads
branch
from
bd5c672 to
34bc350
Compare
|
Will this get merged soon ? I wonder if #1451 helps with the remaining buggy textures 🤔 |
roamic
force-pushed
the
fix-false-positive-image-reuploads
branch
from
b940e53 to
05ae3ef
Compare
|
The latest commit should solve remaining issues in a non-hacky way. |
|
Thank you! Did some rounds of testing with Bloodborne in an heavy area that would produce rainbow corruptions after hitting enemies very fast, haven't seen any so far. If this doesn't regress other games I would merge soon 👍 |
|
Tested through Central Yharnam, killed every enemies like I did last time, not a single rainbow, will try a few more runs but usually I get at least 1, this is amazing work ! |
|
Played about ca. 45 minutes, I could not find any rainbow/metallic/grey textures. Looks very good. |
|
After one hour I found one metallic/grey texture:
|
|
|
roamic
force-pushed
the
fix-false-positive-image-reuploads
branch
from
2b820c5 to
2b9c17e
Compare
|
Couldn't capture it since it was quick but while hitting an enemy he turned rainbow for a second until I hit him again, beside that didn't see any other rainbows |
I've seen this too, thought I fixed it with hash initialization. Seems not. |
|
This has been going on for quite some time. Even before the blackness/rainbow fix and with mod from Nexus fix. It's just very rare and hard to pay attention to. By the way, the rainbow effect on enemies, happens even in the version with the hack. Short. But still. |
roamic
force-pushed
the
fix-false-positive-image-reuploads
branch
from
2b9c17e to
c24476c
Compare
roamic
force-pushed
the
fix-false-positive-image-reuploads
branch
from
c24476c to
0301af9
Compare
roamic
force-pushed
the
fix-false-positive-image-reuploads
branch
from
0301af9 to
1772826
Compare
|
Killed everyone in Central Yharnam like usual, not a single rainbow, this might be the one, I'll try a few more times to make sure but it's looking good ! |
* Fixed false-positive image reuploads * Fixed userfaultfd path, removed dead code, simplified calculations * oopsie * track potentially dirty images and hash them * untrack only first page of the image in case of head access * rebase, initialize hash, fix bounds check * include image tail in the calculations
* Fixed false-positive image reuploads * Fixed userfaultfd path, removed dead code, simplified calculations * oopsie * track potentially dirty images and hash them * untrack only first page of the image in case of head access * rebase, initialize hash, fix bounds check * include image tail in the calculations
This reverts commit 18a36c5.
* Fixed false-positive image reuploads * Fixed userfaultfd path, removed dead code, simplified calculations * oopsie * track potentially dirty images and hash them * untrack only first page of the image in case of head access * rebase, initialize hash, fix bounds check * include image tail in the calculations
* Fixed false-positive image reuploads * Fixed userfaultfd path, removed dead code, simplified calculations * oopsie * track potentially dirty images and hash them * untrack only first page of the image in case of head access * rebase, initialize hash, fix bounds check * include image tail in the calculations
Should fix half of the rainbow artifacts in BloodBorne.
Big thanks to @raphaelthegreat and @psucien for helping debug and fix this.