-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
gui: start the emulator in new thread #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DanielSvoboda Can you help with the Qt window crash when resizing. |
@ngoquang2708 There is a moment when the active window overlaps the previous one, just like now, when a PR with a status column was added, an empty rectangle appears, which freezes when closed and you have to stop the emulator. I suppose you are aware of this. |
I think those issues are not relevant to this PR though. |
In testing this, it fixes the issue with the main window stuck in a loop of not responding while the game window is running. So now once I launch a game, I can tab to the main emulator window and change settings. Two issues that still remain and are not resolved by this MR:
For reference: |
I tested this fix, and it seems to be working well for me. Thanks for the work! Edit: Yeah, userfaultfd is causing problems for me too when trying to A/B vs main. They just merged #1777 minutes ago, so that should no longer be a problem and is unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is quite useful
Fix Qt GUI not responding in Linux.
Fix: #882.