Skip to content

gui: start the emulator in new thread #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

ngoquang2708
Copy link
Contributor

@ngoquang2708 ngoquang2708 commented Dec 19, 2024

Fix Qt GUI not responding in Linux.

Fix: #882.

@ngoquang2708
Copy link
Contributor Author

@DanielSvoboda Can you help with the Qt window crash when resizing.

@ngoquang2708 ngoquang2708 marked this pull request as ready for review December 19, 2024 17:51
@GHU7924
Copy link

GHU7924 commented Dec 19, 2024

@ngoquang2708 There is a moment when the active window overlaps the previous one, just like now, when a PR with a status column was added, an empty rectangle appears, which freezes when closed and you have to stop the emulator.
In addition, when installing *.pkg, the progress was not displayed, if I remember correctly.

I suppose you are aware of this.

@ngoquang2708
Copy link
Contributor Author

I think those issues are not relevant to this PR though.

@EmptyVisual
Copy link

EmptyVisual commented Dec 20, 2024

In testing this, it fixes the issue with the main window stuck in a loop of not responding while the game window is running. So now once I launch a game, I can tab to the main emulator window and change settings.

Two issues that still remain and are not resolved by this MR:

  • Closing the game window also closes the entire emulator application.
  • userfaultd still needs to be commented out; otherwise, there’s a persistent hang on the game window within seconds of launching any non-specific game and it does not recover (can hear audio, but the game itself is frozen). This is a blocker for me in testing mains precompiled binaries. I have to remove the userfaultd code every time from the source and compile.

For reference:
Arch
Linux 6.12.4
CPU: Ryzen 5800X
GPU: Radeon 6900 XT (mesa-git-25.0.0_devel.199185.f0797c60e50)

@kavika13
Copy link

kavika13 commented Dec 22, 2024

I tested this fix, and it seems to be working well for me. Thanks for the work!

Edit: Yeah, userfaultfd is causing problems for me too when trying to A/B vs main. They just merged #1777 minutes ago, so that should no longer be a problem and is unrelated to this PR.

Copy link
Contributor

@raphaelthegreat raphaelthegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is quite useful

@raphaelthegreat raphaelthegreat merged commit aba2b29 into shadps4-emu:main Dec 22, 2024
10 checks passed
@ngoquang2708 ngoquang2708 deleted the emu-thread branch December 23, 2024 14:16
Xcedf pushed a commit to Xcedf/shadPS4 that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linux] Once game starts, main UI stops responding
5 participants