Fix AutoUpdate Issue with Non-Latin Usernames/Directories #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I put it as 'draft', as it is not working correctly yet |
|
Now it works correctly, it has been tested. |
DanielSvoboda
changed the title
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 29, 2024
…u#1853) * Fix updater for non-Latin user directories * QStandardPaths
Xcedf
pushed a commit
to Xcedf/shadPS4
that referenced
this pull request
Dec 29, 2024
…u#1853) * Fix updater for non-Latin user directories * QStandardPaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this update, users who have usernames with Russian or other non-Latin characters can now use AutoUpdate without encountering the error shown in the image below.
UTF-8 BOM Encoding for .ps1 File
.ps1file containing PowerShell commands is now saved with UTF-8 BOM encoding.scriptFile.write("\xEF\xBB\xBF");to ensure the correct encoding.Fix for Non-Latin Characters in Folder Paths
QStandardPaths::writableLocationensures proper handling of non-Latin characters (e.g., Russian characters) in folder paths.Temporary Folder Path Update
Testing
Print of the test I did with the code running in a folder in Russian (Администратор)
It was also tested by a user on discord who presented the problem, and with his user it worked correctly.