Fix amdgpu & other issues #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain what these changes are for? |
|
It likely refers to issue #1994, which is about shadPS4 failing to compile with GCC on one of the AMDGPU related files. |
|
Okay. I don't really understand the need for the swizzle init change, but for the |
liberodark
force-pushed
the
main
branch
2 times, most recently
from
f348c20 to
de72ebf
Compare
|
In the CompMapping structure, we had initialization issues with brace initialization lists. The fix uses explicit member construction to avoid compilation errors. Also this fix issue on GCC14 |
liberodark
force-pushed
the
main
branch
3 times, most recently
from
2e7b5fb to
71eeede
Compare
squidbus
approved these changes
Jan 2, 2025
2 tasks
Xcedf
added a commit
to Xcedf/shadPS4
that referenced
this pull request
Jan 5, 2025
This reverts commit 596f4cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream some fixes from nixos package.