Add throttling counters #500
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Summary
Testing
npm test
PR Type
Bug fix, Tests
Description
Record
loadType
viamonitorEvent
when throttling occursAdd unit tests for rate-limiting metrics and throttling behavior
Ensure fallback to
nestedCountersInstance.countEvent
ifmonitorEvent
unavailableImprove observability of throttling events in rate limiting
Changes walkthrough 📝
index.ts
Record throttling events using monitorEvent with loadType
src/rate-limiting/index.ts
Context.shardus.monitorEvent
to record throttling by loadTypenestedCountersInstance.countEvent
ifmonitorEvent
isunavailable
index.test.ts
Add unit tests for rate-limiting throttling metrics
test/unit/src/rate-limiting/index.test.ts
RateLimiting.isOverloaded
throttling logicmonitorEvent
is called with correct parameters whenoverloaded
monitorEvent
is not called when under limit