-
Notifications
You must be signed in to change notification settings - Fork 119
Refine the document for getting start #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine the document for getting start #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DEVELOPMENT.MD
file is a copy from Tekton Pipelines, https://github.com/tektoncd/pipeline/blob/master/DEVELOPMENT.md plus adjustments for the build project. Please make appropriate changes to the copyright header of the file to comply with article 4 of the Apache License.
Hi Sascha, What should I add in the header? I also view other DEVELOPMENT.md, some of them are similar, such as knative/serving md: They all follow the similar way. I am not sure if we also need to add the other license for the md format? |
I would change the file header to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start and has a lot of good details that are missing in the existing docs.
I think with this and HACK.md
we have two overlapping documents that IMO should target different audiences.
Others should weigh in, personally I'd like to see the following:
- A "Getting Started" guide to target an end-user who does not want to build from source. Perhaps we can simplify matters and assume the end user knows what Kubernetes is and has access to a cluster. The goal is to provide instructions on how to install Shipwright, create a Build, and start a BuildRun.
- A "Hacking" guide to target contributors - instructions on how to compile, test the operator locally, deploy your hacked version on a cluster, etc.
Hi Sascha, I also correct the Copyright |
DEVELOPMENT.md
Outdated
1. Set up a docker repository for pushing images. You can use any container | ||
image registry by adjusting the authentication methods and repository paths | ||
mentioned in the sections below. | ||
- [Docker Hub quickstart](https://docs.docker.com/docker-hub/) | ||
- [IBM Container Registry quickstart](https://cloud.ibm.com/docs/Registry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to be a bit more neutral here:
1. Set up a docker repository for pushing images. You can use any container | |
image registry by adjusting the authentication methods and repository paths | |
mentioned in the sections below. | |
- [Docker Hub quickstart](https://docs.docker.com/docker-hub/) | |
- [IBM Container Registry quickstart](https://cloud.ibm.com/docs/Registry) | |
1. Set up a container image repository for pushing images. Any container image registry that is accessible to your cluster can be used for your repository. This can be a public registry like [Docker Hub])(https://docs.docker.com/docker-hub/), [quay.io](https://quay.io), or a container registry run by your cloud provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. Done
Hi @SaschaSchwarze0 , @adambkaplan or all, Do you have any suggestions? If no other suggestion, I will go ahead to merge this PR. Thanks! |
Hi, you just mentioned me. Please be aware that I am on vacation and come back October 5th.
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For requirement: https://kubernetes.slack.com/archives/C019ZRGUEJC/p1600182959018100
Want to contribute
block more in the main READMEdeploying.md
DEVELOPMENT.md
Features
block in the main README because it is already out-of-date