Skip to content

Bump playwright from 1.51.1 to 1.52.0 #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2025
Merged

Bump playwright from 1.51.1 to 1.52.0 #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8a49c0
Bump playwright from 1.51.1 to 1.52.0
dependabot[bot] Apr 26, 2025
84a852c
Update dev docker image
acelaya Apr 26, 2025
a8a9299
Increase timeout when looking for tooltips
acelaya Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/playwright:v1.51.1-noble
FROM mcr.microsoft.com/playwright:v1.52.0-noble

ENV NODE_VERSION 22.14
ENV TINI_VERSION v0.19.0
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-simple-import-sort": "^12.1.1",
"history": "^5.3.0",
"playwright": "^1.51.1",
"playwright": "^1.52.0",
"sass": "^1.87.0",
"typescript": "^5.8.3",
"typescript-eslint": "^8.30.1",
Expand Down
1 change: 1 addition & 0 deletions test/overview/Overview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@
[{}, false],
])('displays amounts of bots when hovering visits cards', async (visits, excludeBots) => {
const { user } = setUp(false, visits);
const expectTooltipToBeInTheDocument = async (tooltip: string) => waitFor(

Check failure on line 94 in test/overview/Overview.test.tsx

View workflow job for this annotation

GitHub Actions / ci / unit-tests (22.x)

test/overview/Overview.test.tsx > <Overview /> > displays amounts of bots when hovering visits cards 

TestingLibraryElementError: Found multiple elements with the text: /potential bot visits$/

Here are the matching elements:

Ignored nodes: comments, script, style
<div
  class="tooltip-inner"
  role="tooltip"
>
  Plus
   
  <strong>
    1,000
  </strong>
   potential bot visits
</div>

Ignored nodes: comments, script, style
<div
  class="tooltip-inner"
  role="tooltip"
>
  Plus
   
  <strong>
    15
  </strong>
   potential bot visits
</div>

(If this is intentional, then use the `*AllBy*` variant of the query (like `queryAllByText`, `getAllByText`, or `findAllByText`)).

Ignored nodes: comments, script, style
<body>
  
    
  
  


  <div>
    <div
      class="row"
    >
      <div
        class="col-lg-6 col-xl-3 mb-3"
      >
        <a
          class="highlight-card card card-body"
          data-discover="true"
          href="/server/123/non-orphan-visits"
        >
          <svg
            aria-hidden="true"
            class="svg-inline--fa fa-circle-right fa-3x highlight-card__link-icon"
            data-icon="circle-right"
            data-prefix="far"
            focusable="false"
            role="img"
            viewBox="0 0 512 512"
            xmlns="http://www.w3.org/2000/svg"
          >
            <path
              d="M464 256A208 208 0 1 1 48 256a208 208 0 1 1 416 0zM0 256a256 256 0 1 0 512 0A256 256 0 1 0 0 256zM294.6 135.1c-4.2-4.5-10.1-7.1-16.3-7.1C266 128 256 138 256 150.3V208H160c-17.7 0-32 14.3-32 32v32c0 17.7 14.3 32 32 32h96v57.7c0 12.3 10 22.3 22.3 22.3c6.2 0 12.1-2.6 16.3-7.1l99.9-107.1c3.5-3.8 5.5-8.7 5.5-13.8s-2-10.1-5.5-13.8L294.6 135.1z"
              fill="currentColor"
            />
          </svg>
          <div
            class="lh-sm fw-semibold text-uppercase fs-5 highlight-card__title card-title"
          >
            Visits
          </div>
          <p
            class="fs-2 fw-semibold lh-sm card-text"
          >
            2,456
          </p>
        </a>
      </div>
      <div
        class="col-lg-6 col-xl-3 mb-3"
      >
        <a
          class="highlight-card card card-body"
          data-discover="true"
          href="/server/123/orphan-visits"
        >
          <svg
            aria-hidden="true"
            class="svg-inline--fa fa-circle-right fa-3x highlight-card__link-icon"
            data-icon="circle-right"
            data-prefix="far"
            focusable="false"
            role="img"
            viewBox="0 0 512 512"
            xmlns="http://www.w3.org/2000/svg"
          >
            <path
              d="M464 256A208 208 0 1 1 48 256a208 208 0 1 1 416 0zM0 256a256 256 0 1 0 512 0A256 256 0 1 0 0 256zM294.6 135.1c-4.2-4.5-10.1-7.1-16.3-7.1C266 128 256 138 256 150.3V208H160c-17.7 0-32 14.3-32 32v32c0 17.7 14.3 32 32 32h96v57.7c0 12.3 10 22.3 22.3 22.3c6.2 0 12.1-2.6 16.3-7.1l99.9-107.1c3.5-3.8 5.5-8.7 5.5-13.8s-2-10.1-5.5-13.8L294.6 135.1z"
              fill="currentColor"
            />
          </svg>
          <div
            class="lh-sm fw-semibold text-uppercase fs-5 highlight-card__title card-title"
          >
            Orphan visits
          </div>
          <p
            class="fs-2 fw-semibold lh-sm card-text"
          >
            13
          </p>
        </a>
      </div>
      <div
        class="col-lg-6 col-xl-3 mb-3"
      >
        <a
          class="highlight-card card card-body"
          data-discover="true"
          href="/server/123/list-short-urls/1"
        >
          <svg
            aria-hidden="true"
            class="svg-inline--fa fa-circle-right fa-3x highlight-card__link-icon"
            data-icon="circle-right"
            data-prefix="far"
            focusable="false"
            role="img"
            viewBox="0 0 512 512"
            xmlns="http://www.w3.org/2000/svg"
          >
            <path
              d="M464 256A208 208 0 1 1 48 256a208 208 0 1 1 416 0zM0 256a256 256 0 1 0 512 0A256 256 0 1 0 0 256zM294.6 135.1c-4.2-4.5-10.1-7.1-16.3-7.1C266 128 256 138 256 150.3V208H160c-17.7 0-32 14.3-32 32v32c0 17.7 14.3 32 32 32h96v57.7c0 12.3 10 22.3 22.3 22.3c6.2 0 12.1-2.6 16.3-7
() => expect(screen.getByText(/potential bot visits$/)).toHaveTextContent(tooltip),
{ timeout: 2000 },
);

await user.hover(screen.getByText(/^Visits/));
Expand Down
2 changes: 1 addition & 1 deletion test/overview/helpers/VisitsHighlightCard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('<VisitsHighlightCard />', () => {
const { user } = setUp({ title: 'Foo' });

await user.hover(screen.getByText('Foo'));
await waitFor(() => expect(screen.queryByText(/potential bot visits$/)).not.toBeInTheDocument());
await waitFor(() => expect(screen.queryByText(/potential bot visits$/)).not.toBeInTheDocument(), { timeout: 2000 });
});

it('renders tooltip when summary has bots', async () => {
Expand Down
Loading