PoolCluster : TypeError: cb is not a function

[jcmartineztiempo]

This error occurs when you call getConnection method on PoolNamespace instance.

The lib/pool_cluster.js file requires a cb parameter (1 argument) but it's undefined because PromisePoolCluster.getConnection in promise.js sends three (3) arguments: pattern, selector and a callback function, so wether calls getConnection without any argument, the cb argument is always undefined.

MyClass.ts

private get connection(): Promise<PoolConnection> {
  return this._connection ??= this.pool.getConnection();
}

promise.js

class PromisePoolCluster extends EventEmitter {
  constructor(poolCluster, thePromise) {
    super();
    this.poolCluster = poolCluster;
    this.Promise = thePromise || Promise;
    inheritEvents(poolCluster, this, ['warn', 'remove']);
  }

  getConnection(pattern, selector) {
    const corePoolCluster = this.poolCluster;
    return new this.Promise((resolve, reject) => {
      corePoolCluster.getConnection(pattern, selector, (err, coreConnection) => {
        if (err) {
          reject(err);
        } else {
          resolve(new PromisePoolConnection(coreConnection, this.Promise));
        }
      });
    });
  }

pool_cluster.js

class PoolNamespace {
  constructor(cluster, pattern, selector) {
    this._cluster = cluster;
    this._pattern = pattern;
    this._selector = makeSelector[selector]();
  }

  getConnection(cb) {
    const clusterNode = this._getClusterNode();
    if (clusterNode === null) {
      return cb(new Error('Pool does Not exists.'));
    }
    return this._cluster._getConnection(clusterNode, (err, connection) => {
      if (err) {
        return cb(err);
      }
      if (connection === 'retry') {
        return this.getConnection(cb);
      }
      return cb(null, connection);
    });
  }

Environment

• nodejs: v20.11.1
• mysql2: v3.11.3

[wellwelwel]

Probably related:

• Add pattern and selector to PromisePoolCluster#getConnection #3017

[jcmartineztiempo]

Adding some info:

I think that bug resides in PromisePoolCluster.of (promise.js). Instead of return a "PromisePoolNamespace" it returns another PromisePoolCluster:

of(pattern, selector) {
  return new PromisePoolCluster(
    this.poolCluster.of(pattern, selector),
    this.Promise,
  );
}

Maybe, creating a PromisePoolNamespace class like this, and returning an instance of this class by PromisePoolCluster.of, it will be fixed:

class PromisePoolNamespace {

  constructor(poolNamespace, thePromise) {
    this.poolNamespace = poolNamespace;
    this.Promise = thePromise || Promise;
  }

  getConnection() {
    const corePoolNamespace = this.poolNamespace;
    return new this.Promise((resolve, reject) => {
      corePoolNamespace.getConnection((err, coreConnection) => {
        if (err) {
          reject(err);
        } else {
          resolve(new PromisePoolConnection(coreConnection, this.Promise));
        }
      });
    });
  }
}

of(pattern, selector) {
  return new PromisePoolNamespace(
    this.poolCluster.of(pattern, selector),
    this.Promise,
  );
}

[jcmartineztiempo]

Hi, when will it be merged and released?