Exclude lz4 transitive dependency #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I remember the latest flightrecorder jar does not work with java8. |
Aw yes, I think you're right. Let me just drop the transitive dep then. I'll just reuse this PR. |
breedx-splk
changed the title
laurit
approved these changes
May 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently behind a major version of flightrecorder for some reason. Not sure why renovate didn't pick it up (but maybe just because it's a major). UPDATE: as @laurit pointed out, the latest major version is not compatible with java8, which unfortunately, we still have to support.
Furthermore, we have a transitive dependency on
lz4-javawhich contains binary libs (.soand.dynlibfiles), and there's a long-standing CVE that triggers on those binaries. The transitive dependency comes in throughjmcviaflightrecorder. Unfortunately, even this new/latest version of flightrecorder still depends on an old/vulnerable version oflz4-java(see here).See also the discussions in the
lz4-javaissues #217 and #221. It looks likelz4-javais probably abandonware at this point, and jmc will either fork it or drop the dependency.In the meantime, there's really no need for us to include the lz4 dependency at all -- we don't use lz4 compressed flightrecorder files. I tested JFR-based profiling with this latest setting and confirmed that the the telemetry looks good and that the lz4 classes and binaries no longer show up in our distro.