Fixes #846 #847
Merged
Fixes #846 #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis <[email protected]>
DarkaMaul
force-pushed
the
dm/fix-time-utc
branch
from
1eb4106 to
793b720
Compare
|
Would you be able to confirm that the timestamp client here properly handles timezones/UTC? I would assume yes since we're just using the standard library. |
haydentherapper
previously approved these changes
Oct 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 52.85% 45.92% -6.94%
==========================================
Files 20 55 +35
Lines 1209 2942 +1733
==========================================
+ Hits 639 1351 +712
- Misses 509 1451 +942
- Partials 61 140 +79 ☔ View full report in Codecov by Sentry. |
Yes - confirmed this this morning. |
Signed-off-by: Alexis <[email protected]>
cpanato
approved these changes
Oct 7, 2024
haydentherapper
approved these changes
Oct 7, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the problem highlighted in #846 .
Release Note
FIX TimestampResponse Time were not properly returned as GMT.
Documentation
None