[Stats] Add percentage columns #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinSilverfin
force-pushed
the
agustin-expand-stats-with-percentages
branch
from
d90de33 to
22d4c5b
Compare
AgustinSilverfin
force-pushed
the
agustin-expand-stats-with-percentages
branch
2 times, most recently
from
69658f9 to
2c9b9b2
Compare
Toby-Masters-SF
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Hi Rufo,
Review complete. Had a couple of very minor style suggestions (please feel free to take them or leave them)
Only point I wanted to push back on was the calculation of the total YAML test % - as I'm not sure whether we should include shared parts and export files
Calculate the amount of templates that are externally managed and have unit tests Add them to new columns in the output csv file Include percentange in the overview displayed on the terminal
AgustinSilverfin
force-pushed
the
agustin-expand-stats-with-percentages
branch
from
2c9b9b2 to
5eb4d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculate the amount of templates that are externally managed and have unit tests
Add them to new columns in the output csv file
Include percentage in the overview displayed on the terminal
Type of change
Checklist