Skip to content

chore(deps): add missing thecodingmachine/safe dependency #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

simPod
Copy link
Owner

@simPod simPod commented Jul 18, 2022

  • use Safe\pcntl_signal
  • drop Safe\sprintf

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #55 (fc4808e) into master (80853e9) will decrease coverage by 2.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     81.34%   79.22%   -2.13%     
  Complexity       55       55              
============================================
  Files             8        8              
  Lines           193      154      -39     
============================================
- Hits            157      122      -35     
+ Misses           36       32       -4     
Impacted Files Coverage Δ
.../Clients/Consumer/Exception/IncompatibleStatus.php 100.00% <ø> (ø)
src/Clients/Consumer/KafkaConsumer.php 64.93% <ø> (-5.07%) ⬇️
src/Clients/Consumer/WithSignalControl.php 92.85% <ø> (+3.96%) ⬆️
src/Clients/Producer/KafkaProducer.php 82.60% <ø> (-3.11%) ⬇️
src/Common/Config.php 100.00% <0.00%> (ø)
src/Clients/Consumer/BatchTime.php 100.00% <0.00%> (ø)
src/Clients/Consumer/ConsumerRecords.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80853e9...fc4808e. Read the comment docs.

@simPod simPod changed the title chore(deps): remove thecodingmachine/phpstan-safe-rule chore(deps): add missing thecodingmachine/safe dependency Jul 18, 2022
- use Safe\pcntl_signal
- drop Safe\sprintf
@simPod simPod merged commit 7f93e7a into master Jul 18, 2022
@simPod simPod deleted the safe branch July 18, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant