Module names that end in a trialing slash should not be considered builtin #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
It is a common practice to differentiate local packages, from builtin packages with the same name, by adding a trailing slash. So a builtin module name with a trailing slash is an explicit signal to the node module loader to NOT use the builtin module.
For example, the punycode module advises users to add a trailing slash to have node load the npm installed module rather than the builtin module. (See https://github.com/mathiasbynens/punycode.js)
This will fix this upstream bug in rollup. (See rollup/plugins#1211)