Skip to content

verbose mode added #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pmpontes
Copy link

@pmpontes pmpontes commented Jun 6, 2018

Support for verbose mode included in response to issue #14

@sindresorhus
Copy link
Owner

This doesn't correctly handle input when it's a glob as it should then show the resolved files from the glob, not the actual glob pattern. It also does not handle the case where the supplied path doesn't exist as it will still log it as removed.

@pmpontes
Copy link
Author

pmpontes commented Jun 6, 2018

I see, @sindresorhus . The proper way to handle input when it's a glob and also handle the case where the supplied path doesn't exist, would be to make the promise trash returns include an argument specifying a list of the files deleted, otherwise I can't think of another workaround.

@sindresorhus
Copy link
Owner

would be to make the promise trash returns include an argument specifying a list of the files deleted, otherwise I can't think of another workaround.

Correct, but even that is not that easy as trash uses native binaries, so they would have to be modified to return the paths of trashed files too. I'm starting to wonder if it's really worth the effort.

@sindresorhus
Copy link
Owner

Closing for lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants