SNOW-2041980 Kerberos Proxy Auth - NodeJS #1102

sfc-gh-ext-simba-jy · 2025-06-16T18:53:17Z

Description

Please explain the changes you made here.

Added the customizer Header connection configs
In request Util, create some functions to validate customizer headers and get headers
Added 'isRetry' options in snowflake connection requests and GCS and S3 utils (It can be in remote_util, but difficult to test)
Added testings.

Checklist

Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
Create tests which fail without the change (if possible)
Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
Extend the types in index.d.ts file (if necessary)
Extend the README / documentation and ensure is properly displayed (if necessary)
Provide JIRA issue id (if possible) or GitHub issue id in commit message

codecov · 2025-06-18T03:02:16Z

Codecov Report

Attention: Patch coverage is 85.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (9200f50) to head (0086cd2).

Files with missing lines	Patch %	Lines
lib/connection/statement.js	16.66%	5 Missing ⚠️
lib/file_transfer_agent/remote_storage_util.js	20.00%	4 Missing ⚠️
lib/file_transfer_agent/s3_util.js	73.33%	4 Missing ⚠️
lib/file_transfer_agent/gcs_util.js	87.50%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.02%     
==========================================
  Files          83       83              
  Lines        7689     7775      +86     
  Branches       67       67              
==========================================
+ Hits         6892     6968      +76     
- Misses        790      800      +10     
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sfc-gh-rsavenok · 2025-06-20T13:26:52Z

package.json

-    "test": "mocha 'test/unit/**/*.{js,ts}'",
-    "test:authentication": "mocha 'test/authentication/**/*.{js,ts}'",
-    "test:integration": "mocha 'test/integration/**/*.{js,ts}'",
+    "test": "mocha test/unit/**/*.{js,ts}",


The quotes were added recently in #1079

Mocha's behaviour is poorly documented: when a test pattern is passed without quotes, it uses the default shell pattern matching mechanism (different on every OS/shell), and if a string is passed, it uses glob from the npm package.

You can confirm this by running npm run test:unit on a command with quotes and without, and you'll see that it runs 300 fewer tests if quotes aren't set 🙈

Hmmm, interesting. On my machine(Windows), I cannot execute the npm command with the quote, and the 791 unit testing were executed without the quote. Anyway, I will have a look and let you know if I find any other solutions. I will revert this back when I need to update the PR based on the feedbacks. Thank you.

Mocha Docs

Maybe it should be double quotes instead of single to work correctly?

You should always quote your globs in npm scripts. If you use quotes, the node-glob module will handle its expansion. For maximum compatibility, surround the entire expression with double quotes and refrain from $, ", ^, and \ within your expression.

Yes, it worked well when I replaced the single quote with the double quote. Currently, I revert it back. If you want me to fix this in this PR, I will update it. Please let me know.

sfc-gh-rsavenok · 2025-06-20T13:33:48Z

lib/constants/error_messages.js

@@ -86,6 +86,8 @@ exports[404059] = 'Invalid oauth client id. The specified value must not be an e
 exports[404060] = 'Invalid oauth client secret. The specified value must not be an empty string';
 exports[404061] = 'Invalid oauth token request URL. The specified value must be a valid URL starting with the https or http protocol.';
 exports[404062] = 'No workload identity credentials were found. Provider: %s';
+exports[404063] = 'Invalid http header customizers. The specified value must contain the following functions: \'applices\', \'newHeaders\' and \'invokeOnce\'';


Would suggest to adjust eslint config: 'quotes': ['error', 'single', { 'avoidEscape': true }],

So it lets us use "" instead of '' when a string contains ' :)

It will let us make this line:

exports[404063] = "Invalid http header customizers. The specified value must contain the following functions: 'applices', 'newHeaders' and 'invokeOnce'";

When I replaced the double quote with the single quote, the linter said:

Error: 89:19 error Strings must use singlequote quotes Error: 89:[11](https://github.com/snowflakedb/snowflake-connector-nodejs/actions/runs/15858048698/job/44708146624?pr=1102#step:5:12)1 error Unnecessary escape character: \' no-useless-escape Error: 89:[12](https://github.com/snowflakedb/snowflake-connector-nodejs/actions/runs/15858048698/job/44708146624?pr=1102#step:5:13)1 error Unnecessary escape character: \' no-useless-escape Error: 89:125 error Unnecessary escape character: \' no-useless-escape Error: 89:[13](https://github.com/snowflakedb/snowflake-connector-nodejs/actions/runs/15858048698/job/44708146624?pr=1102#step:5:14)7 error Unnecessary escape character: \' no-useless-escape Error: 89:[14](https://github.com/snowflakedb/snowflake-connector-nodejs/actions/runs/15858048698/job/44708146624?pr=1102#step:5:15)4 error Unnecessary escape character: \' no-useless-escape Error: 89:[15](https://github.com/snowflakedb/snowflake-connector-nodejs/actions/runs/15858048698/job/44708146624?pr=1102#step:5:16)6 error Unnecessary escape character: \' no-useless-escape

Currently, the linter enforces the use of single quotes only.

sfc-gh-rsavenok · 2025-06-20T13:37:36Z

lib/util.ts

@@ -678,3 +683,19 @@ export function escapeHTML(value: string) {
 export async function dynamicImportESMInTypescriptWithCommonJS(moduleName: string) {
  return Function(`return import("${moduleName}")`)()
 }
+
+export function isValidHTTPHeaderCustomizers(customizers: HttpHeadersCustomizer[]) : boolean {


In one of the recent PRs, there was a discussion that util file is a mess and we should try to reduce it's size by moving helpers next to business logic that needs them.

Would suggest to move both this helper function and HttpHeadersCustomizer type http folder:

add types.ts

helper in request_util.js

sfc-gh-rsavenok · 2025-06-24T13:12:09Z

package.json

-    "test": "mocha 'test/unit/**/*.{js,ts}'",
-    "test:authentication": "mocha 'test/authentication/**/*.{js,ts}'",
-    "test:integration": "mocha 'test/integration/**/*.{js,ts}'",
+    "test": "mocha test/unit/**/*.{js,ts}",


Mocha Docs

Maybe it should be double quotes instead of single to work correctly?

You should always quote your globs in npm scripts. If you use quotes, the node-glob module will handle its expansion. For maximum compatibility, surround the entire expression with double quotes and refrain from $, ", ^, and \ within your expression.

sfc-gh-fpawlowski · 2025-06-24T14:41:39Z

Wouldn't it make sense to use this HttpInterceptor class for headers customziation?

https://github.com/snowflakedb/snowflake-connector-nodejs/blob/master/test/integration/test_utils/httpInterceptorUtils.js

sfc-gh-ext-simba-jy · 2025-06-24T21:05:16Z

Wouldn't it make sense to use this HttpInterceptor class for headers customziation?

https://github.com/snowflakedb/snowflake-connector-nodejs/blob/master/test/integration/test_utils/httpInterceptorUtils.js

I will have a look. It looks the interceptor you mentioned is for the testing purpose.

sfc-gh-ext-simba-jy added 2 commits June 16, 2025 11:52

implement custom headers

40b6887

fix

6f883b5

sfc-gh-ext-simba-jy changed the title ~~implement custom headers~~ SNOW-2041980 Kerberos Proxy Auth - NodeJS Jun 17, 2025

sfc-gh-ext-simba-jy added 7 commits June 17, 2025 14:12

fix

3148082

fox

23c705c

fix

968f47d

fix

5bed016

fix

14956d9

fix

5a8ff03

fix

631f3ef

sfc-gh-ext-simba-jy marked this pull request as ready for review June 18, 2025 02:59

sfc-gh-ext-simba-jy requested a review from a team as a code owner June 18, 2025 02:59

sfc-gh-ext-simba-jy requested review from sfc-gh-dheyman and sfc-gh-rsavenok June 18, 2025 02:59

sfc-gh-ext-simba-jy and others added 3 commits June 18, 2025 17:05

fix

ec38d19

Merge branch 'master' into SNOW-2041980v2

d68e1cd

add one more testing and fix error after merging

3cab6a0

sfc-gh-rsavenok reviewed Jun 20, 2025

View reviewed changes

sfc-gh-ext-simba-jy added 2 commits June 23, 2025 18:43

fix

5ce02c0

add

569f179

sfc-gh-ext-simba-jy requested a review from sfc-gh-rsavenok June 24, 2025 01:44

sfc-gh-rsavenok reviewed Jun 24, 2025

View reviewed changes

sfc-gh-ext-simba-jy and others added 6 commits June 24, 2025 11:02

Update error_messages.js

72b636f

Merge branch 'master' into SNOW-2041980v2

9089ca5

fix

4d967cf

reverted back package.json

322dd1e

fix

1085ac8

fix

d85b981

sfc-gh-ext-simba-jy added 6 commits June 24, 2025 12:14

fix the type

7978fdf

testing

edfb6b1

testing js

0443abc

fix

aa27396

fix

68f536c

testing

0086cd2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SNOW-2041980 Kerberos Proxy Auth - NodeJS #1102

SNOW-2041980 Kerberos Proxy Auth - NodeJS #1102

sfc-gh-ext-simba-jy commented Jun 16, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

sfc-gh-rsavenok Jun 20, 2025 •

edited

Loading

Uh oh!

sfc-gh-ext-simba-jy Jun 20, 2025

Uh oh!

sfc-gh-rsavenok Jun 24, 2025

Uh oh!

sfc-gh-ext-simba-jy Jun 24, 2025

Uh oh!

sfc-gh-rsavenok Jun 20, 2025

Uh oh!

sfc-gh-ext-simba-jy Jun 24, 2025

Uh oh!

sfc-gh-rsavenok Jun 20, 2025

Uh oh!

sfc-gh-rsavenok Jun 24, 2025

Uh oh!

sfc-gh-fpawlowski commented Jun 24, 2025

Uh oh!

sfc-gh-ext-simba-jy commented Jun 24, 2025

Uh oh!

Uh oh!

SNOW-2041980 Kerberos Proxy Auth - NodeJS #1102

Are you sure you want to change the base?

SNOW-2041980 Kerberos Proxy Auth - NodeJS #1102

Conversation

sfc-gh-ext-simba-jy commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

codecov bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sfc-gh-rsavenok Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sfc-gh-ext-simba-jy Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-rsavenok Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-ext-simba-jy Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-rsavenok Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-ext-simba-jy Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-rsavenok Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-rsavenok Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-fpawlowski commented Jun 24, 2025

Uh oh!

sfc-gh-ext-simba-jy commented Jun 24, 2025

Uh oh!

Uh oh!

sfc-gh-ext-simba-jy commented Jun 16, 2025 •

edited

Loading

codecov bot commented Jun 18, 2025 •

edited

Loading

sfc-gh-rsavenok Jun 20, 2025 •

edited

Loading