Deal with misleading storage rewards in Inflation struct

[mvines]

This field is now dead code

solana/sdk/src/inflation.rs

Lines 21 to 22 in 58ef02f

	/// Percentage of total inflation allocated to storage rewards
	pub storage: f64,

as of #9992.

Removing it entirely would likely cause a snapshot ABI change, so renaming it to __unused would be an alternative. It should be removed from the getInflation RPC API AS well

[CriesofCarrots]

Storage should also be removed from this calculation as well, correct?

solana/sdk/src/inflation.rs

Line 69 in c600cfc

self.total(year) - self.storage(year) - self.foundation(year)

Right now, in epochs after the foundation term:

• total inflation = 0.015
• validator inflation = 0.0135
  ...due to this

[mvines]

Yeah. Might need @ericlwilliams's help

[ryoqun]

Removing it entirely would likely cause a snapshot ABI change, so renaming it to __unused would be an alternative. It should be removed from the getInflation RPC API AS well

Hm, snapshot 1.3 should remove these fields at once, then? :)

[ericlwilliams]

Yeah seems like that can/should be killed. Unless @aeyakovenko, or anyone else, sees Archivers on the horizon. For the foreseeable future, inflation should be divvied out just between validators and Foundation/Grant pools