Replace `daddr` checks with `ip().is_unspecified()`

[aeyakovenko]

Rust added a function to IpAddr to check if its unspecified. The code should call that method instead of comparing against 0.0.0.0:0.

[martiuslim]

Would love to give this a shot! Would just like to clarify if the below snippets are heading in the right direction for this issue?

• else if v.contact_info.tvu == daddr to else if v.contact_info.tvu.is_unspecified()
• .filter(|r| r.id != self.me && r.contact_info.tvu_window != daddr) to .filter(|r| r.id != self.me && !(r.contact_info.tvu_window.is_unspecified()))

[aeyakovenko]

Yes!

I would define a function ‘is_valid_address’ which checks that the port is nonzero, and address is not unspecified or multicast

[martiuslim]

Ah I see. May I kindly check where would be the best place to define this function?

[aeyakovenko]

Inside the Crdt class, so it can be called context free ‘Crdt::is_valid_address’

[martiuslim]

looks like this can be closed, ref: #721