This repository was archived by the owner on Jan 22, 2025. It is now read-only.
make next_entries() smarter about fitting Transactions into a Blob #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
lgtm! |
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
Apr 11, 2024
buffalojoec
pushed a commit
to buffalojoec/solana
that referenced
this pull request
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous logic assumed that all transactions were the same size, and that simple binary splitting would make them fit into a nice power of 2 Entries
fixes #740