This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Don't subject authorizing a new stake authority to lockup #9434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
approved these changes
Apr 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #9434 +/- ##
======================================
Coverage 81.1% 81.1%
======================================
Files 277 277
Lines 62337 62340 +3
======================================
+ Hits 50598 50602 +4
+ Misses 11739 11738 -1 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2020
(cherry picked from commit 31ebdbc)
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2020
(cherry picked from commit 31ebdbc)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 11, 2020
mvines
pushed a commit
that referenced
this pull request
Apr 12, 2020
(cherry picked from commit 31ebdbc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a stake authority is compromised, the withdraw authority can be used to set a new one. That's currently not true iff the stake account is locked up.
Summary of Changes
Allow the stake authority to be updated when the account is locked up.