This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Advertise node software version in gossip #9981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
commented
May 11, 2020
| let ip_addr = node.gossip.ip(); | ||
| Some(format!( | ||
| "{:15} {:2}| {:5} | {:44} | {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {}\n", | ||
| "{:15} {:2}| {:5} | {:44} |{:^15}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {:5}| {}\n", |
There was a problem hiding this comment.
Display node version in solana-gossip spy...
mvines
commented
May 11, 2020
| @@ -1313,6 +1330,9 @@ impl ClusterInfo { | |||
| let mut last_contact_info_trace = timestamp(); | |||
| let mut adopt_shred_version = obj.my_shred_version() == 0; | |||
| let recycler = PacketsRecycler::default(); | |||
|
|
|||
| let message = CrdsData::Version(Version::new(obj.id())); | |||
| obj.push_message(CrdsValue::new_signed(message, &obj.keypair)); | |||
There was a problem hiding this comment.
Automatically push version when entering gossip
This was referenced May 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #9981 +/- ##
========================================
- Coverage 80.4% 80.2% -0.2%
========================================
Files 284 285 +1
Lines 66235 66299 +64
========================================
- Hits 53263 53231 -32
- Misses 12972 13068 +96 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With RPC disabled by default, it's too hard to monitor the software version that all validators are running.
Motivating example: do we need to start panicking because a rolling update is about to enable and less then 2/3+ of the stake has updated?
The first commit will be backported to v1.0/v1.1, the "Remove solana_clap_utils::version! macro" commit is too much churn and will only land on master.