Skip to content

Adding failing test for issue #1886 #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

theturtle32
Copy link

PR Checklist

This PR is not intended to be merged, just to add a failing e2e test that illustrates the bug which should stop failing once the bug is fixed.

What is the current behavior?

See issue #1886

What is the new behavior?

Added failing tests that should stop failing when the underlying bug is fixed.

Other information

Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: dbbcb70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented May 2, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit dbbcb70
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/6815559f124da80008c6a0be
😎 Deploy Preview https://deploy-preview-1887--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brenelz
Copy link
Contributor

brenelz commented May 6, 2025

Thank you for providing this failing test. I incorporated it in my PR that should be going out in the next release

@brenelz brenelz closed this May 6, 2025
@theturtle32 theturtle32 deleted the issue-1886 branch May 11, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants