Skip to content

fix: generators with server functions #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2025

Conversation

brenelz
Copy link
Contributor

@brenelz brenelz commented May 4, 2025

PR Checklist

Fixes #1886 1886

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

Generators in server functions were not working

What is the new behavior?

This upgrades tanstack server functions plugin which has the updated fix

Other information

Copy link

changeset-bot bot commented May 4, 2025

⚠️ No Changeset found

Latest commit: e2d3bd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented May 4, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit e2d3bd2
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/6816c7c37986a10008be613a
😎 Deploy Preview https://deploy-preview-1888--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brenelz brenelz requested review from atilafassina and birkskyum May 4, 2025 01:23
@birkskyum birkskyum merged commit b7c174c into solidjs:main May 4, 2025
10 checks passed
@birkskyum birkskyum mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: "use server" in async generator is broken
2 participants