Fix server-side testing with vitest/ssr #217
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix server-side testing with vitest/ssr
Initial error
Initial error when running vitest in ssr mode, since
[email protected]
(introduced by #173, reported by #211):Proposed fix
'browser'
ifoptions.ssr
is setI am not familiar with the code, and I am not sure if it could lead to issues for other setups.
An alternative could be to only add
'browser'
if the conditions don't already include'node'
:Let me know which solution seems to be the best.
Additional note
The
opts.isSsrTargetWebworker
check seems to be inconsistant in the original code, I've left it untouched as I am not sure what is the intent there:Can original author comment on if the original logic seems consistent? (cc @bluwy @brenelz)
Thanks!
Fixes #211